Add JdkInstaller #315
Add JdkInstaller #315
Conversation
If JDK 8 is not already installed, JdkInstaller will download the binary and source code at given path.
| const JDK_SRC_ZIP = `jdk${JDK_VERSION}.zip`; | ||
|
|
||
| /** | ||
| * Checks whether JDK 8 is installed. If not installed, |
There was a problem hiding this comment.
This comment is wrong isn't it? I can't see where this class checks whether JDK 8 is installed.
|
I'm wondering if we should assume the "default" flow as installing the JDK to a default place. This would make the user flow easier. Something like:
If the user answers yes (default), we can just install that into |
|
@PEConn thanks for the review! I think I've addressed your comments now. @andreban I also considered that but ultimately went with letting the user choose the location to have more choice. But I think you're right. Making it install in a default location is simpler for the user. So I've changed it to do this instead. |
| @@ -0,0 +1,94 @@ | |||
| /* | |||
| * Copyright 2019 Google Inc. All Rights Reserved. | |||
There was a problem hiding this comment.
nit: wrong year for the copyright header.
| * Copyright 2019 Google Inc. All Rights Reserved. | |
| * Copyright 2020 Google Inc. All Rights Reserved. |
If JDK 8 is not already installed, JdkInstaller will download
the binary and source code at given path.