Console log #284
Console log #284
Conversation
packages/core/package.json
Outdated
| "devDependencies": { | ||
| "@types/mime-types": "^2.1.0" |
There was a problem hiding this comment.
Can you revert this change, please. mime-types is needed as a runtime dependency. This is also downgrading the minimum version from 2.1.27 to 2.1.0. Generally, devDependencies should be empty in core, cli and validator and listed on the root package.json.
packages/core/src/lib/Log.ts
Outdated
| debug(message: string, ...args: string[]): void; | ||
|
|
||
| /** | ||
| * Prints an info message to the Log. message is ignored if the Log is not set to verbose. |
There was a problem hiding this comment.
These comments seem to be wrong (the bit about verbose only applies to debug I think).
Also, capital letters at the start of sentences please.
There was a problem hiding this comment.
I didn't write it, and I think it is right, if verbose == false it will not print anything
packages/core/package.json
Outdated
| "devDependencies": { | ||
| "@types/mime-types": "^2.1.0" |
There was a problem hiding this comment.
Can you revert this change, please. mime-types is needed as a runtime dependency. This is also downgrading the minimum version from 2.1.27 to 2.1.0. Generally, devDependencies should be empty in core, cli and validator and listed on the root package.json.
packages/core/package.json
Outdated
| "inquirer": "^7.3.2", | ||
| "jimp": "^0.14.0", | ||
| "inquirer": "^7.0.4", | ||
| "sharp": "^0.23.2", |
There was a problem hiding this comment.
Did you mean to change this line?
Changed
Loginto an interface and addedConsoleLog