Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export es2018 code #271

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Export es2018 code #271

merged 1 commit into from
Aug 3, 2020

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Aug 1, 2020

This one small trick will save tons of code! Node v10 supports all es2018 syntax, and using it means async functions and classes aren't transpiled and are easier to debug.

andreban
andreban approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! This will indeed help with crash reports.

@andreban andreban merged commit fb566ff into GoogleChromeLabs:master Aug 3, 2020
@andreban andreban added the enhancement New feature or request label Aug 3, 2020
@NotWoods NotWoods deleted the es2018 branch August 4, 2020 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreban andreban andreban approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotWoods @andreban