Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GradleWrapper can call bundleRelease #241

Merged
merged 3 commits into from
Jul 17, 2020
Merged

GradleWrapper can call bundleRelease #241

merged 3 commits into from
Jul 17, 2020

Conversation

andreban
Copy link
Member

  • Introduces a GradleWrapper method to call gradle bundleRelease
    to produce app bundles as output.

This moves forward work for #119

@andreban
GradleWrapper can call bundleRelease
cb37aa0 
- Introduces a GradleWrapper method to call gradle bundleRelease
  to produce app bundles as output.
@andreban andreban requested a review from PEConn July 16, 2020 20:50
@andreban andreban added the enhancement New feature or request label Jul 16, 2020
@PEConn
Copy link
Collaborator

PEConn commented Jul 17, 2020

This looks good, how are we going to expose it to the user?

@andreban
Copy link
Member Author

andreban commented Jul 17, 2020 •
edited
Loading

We'll need to add a flag to build that outputs bundles. We also need to sign the bundle with jarsigner instead of apksigner. I'll create a PR on that bit soon.

@andreban andreban merged commit fa03925 into GoogleChromeLabs:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PEConn PEConn PEConn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreban @PEConn