Fixes Unhandled Promise Rejections #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added missing `await` calls to fix Unhandled Promis Rejections when renaming the old config name to the new config name. - Defaults CLI to the `help` command
PEConn
reviewed
Jul 1, 2020
packages/cli/src/spec/configSpec.ts
Outdated
| @@ -22,7 +22,7 @@ import {loadOrCreateConfig} from '../lib/config'; | |||
| import * as mock from 'mock-fs'; | |||
| import * as inquirer from 'inquirer'; | |||
|
|
|||
| const DEFAULT_CONFIG_FOLDER = join(homedir(), '.bubblewrap-config'); | |||
| const DEFAULT_CONFIG_FOLDER = join(homedir(), '.bubblewrap'); | |||
| const DEFAULT_CONFIG_NAME = 'bubblewrap-config.json'; | |||
There was a problem hiding this comment.
Maybe we should just change the file name to ~/.bubblewrap/config.json, ~/.bubblewrap/bubblewrap-config.json is a bit tautological.
There was a problem hiding this comment.
Yeah, makes sense. Renamed.
- Renames `bubblewrap-config.json` to `config.json`, as the config already sits in the `~/.bubblewrap` directory.
PEConn
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awaitcalls to fix Unhandled Promis Rejectionswhen renaming the old config name to the new config name.
helpcommand.bubblewrapas the name for the config folder, in case we need to store other files in the future.@chenlevy24 FYI