Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated keystore and twa-config files are not put in the given directory argument. #414

Closed
jingz opened this issue Nov 30, 2020 · 0 comments · Fixed by #421
Closed

Generated keystore and twa-config files are not put in the given directory argument. #414

jingz opened this issue Nov 30, 2020 · 0 comments · Fixed by #421
Labels
bug Something isn't working

Comments

@jingz
Copy link

jingz commented Nov 30, 2020 •
edited
Loading

Describe the bug
Generated keystore and twa-config files are not put in the given directory argument.

To Reproduce
Steps to reproduce the behavior:
bubblewrap init --manifest=/path/to/manintest --directory=adir

Expected behavior
all generated files will be put inside adir

Desktop (please complete the following information):

  • MacOS MoJave

Thanks you.
@andreban andreban added the bug Something isn't working label Nov 30, 2020
andreban added a commit to andreban/llama-pack that referenced this issue Dec 7, 2020
@andreban
Generate config and keys on the correct directory
78b13ba 
- When running `init` with the `--directory` option,
  `twa-manifest.json` was generated in the current directory
  instead of the project directory.
- The `init` method would also suggest the current directory as
  the default for the keystore. This is changed to be inside the
  target directory.

Closes GoogleChromeLabs#414
@andreban andreban mentioned this issue Dec 7, 2020
Merged
andreban added a commit that referenced this issue Dec 8, 2020
@andreban
Generate config and keys on the correct directory (#421)
142ac45 
- When running `init` with the `--directory` option,
  `twa-manifest.json` was generated in the current directory
  instead of the project directory.
- The `init` method would also suggest the current directory as
  the default for the keystore. This is changed to be inside the
  target directory.

Closes #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate config and keys on the correct directory andreban/llama-pack
2 participants
@jingz @andreban