[fix][NPM] Add package.json to exports #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update package.json exports to include package.json. Why package.json needs to export itself, I cannot say but it fixes the following Svelte rollup.js plugin warning: [rollup-plugin-svelte] The following packages did not export their `package.json` file so we could not check the "svelte" field. If you had difficulties importing svelte components from a package, then please contact the author and ask them to export the package.json file. - browser-fs-access I've verified locally using `npm link` that the warning no longer occurs with this change in my Svelte project. I _believe_ the otherwise preexisting exports behavior is preserved. References: - [Official documentation](https://nodejs.org/api/packages.html#packages_exports) and [much more useful documentation with examples from the proposal](https://github.com/jkrems/proposal-pkg-exports) - [Similar issue for a different package](sveltejs/svelte#5659) and [its resolution](https://unpkg.com/svelte@3.29.6/package.json)
|
Version 0.17.3 that includes this has just been released. |
|
@tomayac, thanks for the fast turnaround. The new release appears to function as hoped. Take care! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update package.json exports to include package.json. Why package.json
needs to export itself, I cannot say but it fixes the following Svelte
rollup.js plugin warning:
[rollup-plugin-svelte] The following packages did not export their
package.jsonfile so we could not check the "svelte" field. If you had difficulties importing svelte components from a package, then please contact the author and ask them to export the package.json file.I've verified locally using
npm linkthat the warning no longer occurswith this change in my Svelte project. I believe the otherwise
preexisting exports behavior is preserved.
References: