Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates to remove critical warnings and fix release process #3215

Merged
merged 5 commits into from
May 30, 2023

Conversation

tropicadri
Copy link
Contributor

Dependency updates to remove critical warnings and fix release process

@tropicadri tropicadri requested a review from malchata May 27, 2023 02:07
@tropicadri tropicadri merged commit ee44e68 into v6 May 30, 2023
@rulgf
Copy link

rulgf commented May 31, 2023

Hi
Question, why is removing support for node <= 16 considered a patch release?

Thanks!

@dpobel
Copy link

dpobel commented May 31, 2023

if I understand correctly, node 16 was defined as the minimum required version in 6.6.0 in a "soft" way and then the 6.6.1 enforced it in packages.json. This is breaking the build of our application :(

IMHO this is a BC break should have happened in a 7.0.0

@rulgf
Copy link

rulgf commented May 31, 2023

I agree, this should not be considered a minor/patch release.

@tropicadri could it be possible to move this to 7.0.0 and revert 6.6.1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants