Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(uses-webp): tweak text to be more next-gen focused #3985

Merged
merged 4 commits into from
Dec 13, 2017
Merged

core(uses-webp): tweak text to be more next-gen focused #3985

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a999ab
core(uses-webp): tweak text to be more next-gen focused
patrickhulce Dec 4, 2017
f17348e
feedback
patrickhulce Dec 5, 2017
8d8d348
mooooore
patrickhulce Dec 5, 2017
0d0de57
superior -> next-gen
patrickhulce Dec 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lighthouse-core/audits/byte-efficiency/uses-webp-images.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ class UsesWebPImages extends ByteEfficiencyAudit {
static get meta() {
return {
name: 'uses-webp-images',
description: 'Serve images as WebP',
description: 'Serve images in superior formats',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Superior formats" seems a little judgy. Can we just say "next-gen formats" or "performant formats"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'next-gen' was nixed, but performant SGTM

@paulirish?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind paul's good with "next-gen" afterall 👍

informative: true,
helpText: 'WebP provides better lossy and lossless compression than PNG or JPEG, ' +
'which means faster downloads and less data consumption. ' +
helpText: 'Image formats like JPEG 2000, JPEG XR, and WebP often provide better ' +
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention something here about different browser support for each, or nah?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah we have a policy to keep the details in the docs

'compression than PNG or JPEG, which means faster downloads and less data consumption. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/webp).',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update this documentation to explain the different formats?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed we should

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed a bug against Kayce to update the docs for next sprint :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool cool, I also just got a brain dump from him on how I can update stuff and seems straightforward when we have changes to docs like this that aren't new material :)

requiredArtifacts: ['OptimizedImages', 'devtoolsLogs'],
};
Expand Down