-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(lighthouse-logger): convert to ES modules #13720
Conversation
This only holds for usage of LH directly.... if a user was importing the logger package themselves then of course the breaking change would be they can't |
I think this needs to land first #13722 |
const marky = require('marky'); | ||
import process from 'process'; | ||
import debug from 'debug'; | ||
import * as marky from 'marky'; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@connorjclark, @adamraine: Now that this was released ~2 hours ago, it's started blowing up. Specifically this usage in |
@dlockhart thanks, yeah we are working on a fix |
ref #12689
This is not a breaking change because only conversions to ESM inside
lighthouse-core
would be.The only impact is that the
build-bundle
script will see this file as ESM during rollup (FYI: when bundling we use the local copy, but via Node we use the npm pacakge). I have no plans to publish a new version of the npm package, but if we did, that shouldn't be a breaking change for LH consumers either if LH used that new ESM version.