-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(treemap): add locale to html tag #12731
Conversation
This would fix the problem for english users and the landing page, but we do have some translated strings in the treemap. I'm thinking we have a default value of Basically just stick a document.documentElement.lang = options.lhr.configSettings.locale in here lighthouse/lighthouse-treemap/app/src/main.js Lines 760 to 768 in 8bb2f21
@connorjclark would this work? Additional ref #12647 |
@coliff do you still want this? |
I'm not 100% certain of exactly where that |
Closing in favor of #13454. I'll add you as a co-author. |
Summary
This fixes #12730
The page is missing
lang="en"
attribute. When loading page in Edge it offered to translate the page from Maltese to English for me. Specifying the lang will tell the browser it's in English already.Related Issues/PRs