Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add v8.0 Performance FAQ #12597

Merged
merged 13 commits into from
Jun 2, 2021
Merged

docs: add v8.0 Performance FAQ #12597

merged 13 commits into from
Jun 2, 2021

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Jun 2, 2021

add standalone faq md, and linking it into the v8.0 changelog notes

faq is currently previewable here: https://github.com/GoogleChrome/lighthouse/blob/v8changelog-faq/docs/v8-perf-faq.md

to merge into #12596 (which merges into #12593)

@paulirish paulirish requested a review from a team as a code owner June 2, 2021 01:34
@paulirish paulirish requested review from connorjclark and removed request for a team June 2, 2021 01:34
@google-cla google-cla bot added the cla: yes label Jun 2, 2021
changelog.md Outdated Show resolved Hide resolved
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📜 ❓ 🎯

to TBT changes in the long tail and the windowing of CLS, and both metrics'
higher weights.

### What are the exact score weighting changes?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aw, the github table formatting is kind of a bummer. Maybe throw some italics on the v6 weights column to deemphasize? Should we separate the phase weights somehow (separate table? put the metric names in the middle with different weights on each end?) to make it more readable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attempted something. added some italics on all the phases. i can also try splitting the table out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attempted something. added some italics on all the phases. i can also try splitting the table out.

ah, looks great split like that. Sorry to send you down this rabbit hole. Github really just needs to add one or two more table styling options

docs/v8-perf-faq.md Outdated Show resolved Hide resolved
docs/v8-perf-faq.md Outdated Show resolved Hide resolved
the best incentives to improve overall page experience for users.

LCP, CLS, and TBT are [very good
metrics](https://chromium.googlesource.com/chromium/src/+/lkgr/docs/speed/good_toplevel_metrics.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCP, CLS, and TBT are very good
metrics

https://twitter.com/dog_rates/status/775410014383026176

docs/v8-perf-faq.md Outdated Show resolved Hide resolved

### What's the story with TTI?

TTI serves a useful role as it's the largest metric value reported (often >10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TTI serves a useful role as it's the largest metric value reported (often >10
TTI serves a useful role as it's the longest metric value reported (often >10

maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels weird as longest. but also weird as largest. ohwell

docs/v8-perf-faq.md Outdated Show resolved Hide resolved
docs/v8-perf-faq.md Outdated Show resolved Hide resolved
docs/v8-perf-faq.md Outdated Show resolved Hide resolved
docs/v8-perf-faq.md Outdated Show resolved Hide resolved
docs/v8-perf-faq.md Outdated Show resolved Hide resolved
and that's why they are the three highest-weighted metrics in the performance
score.

### How should I think about the Lighthouse performance score in relation to Core Web Vitals?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump on my offer :)

docs/v8-perf-faq.md Outdated Show resolved Hide resolved
paulirish and others added 2 commits June 2, 2021 09:10
Co-authored-by: Brendan Kenny <bckenny@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
@paulirish paulirish deleted the v8changelog-faq branch June 2, 2021 17:15
@brendankenny brendankenny mentioned this pull request Jun 2, 2021
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants