core(image-elements): do not set untrusted natural dimensions #11457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16caf64 to
450e68a
Compare
patrickhulce
commented
Sep 18, 2020
| @@ -175,7 +177,7 @@ function determineNaturalSize(url) { | |||
| } | |||
|
|
|||
| /** | |||
| * @param {LH.Crdp.CSS.CSSStyle} [style] | |||
| * @param {LH.Crdp.CSS.CSSStyle|undefined} style | |||
There was a problem hiding this comment.
drive by fix, vscode flags this as a ts error
| @@ -191,7 +193,7 @@ function findSizeDeclaration(style, property) { | |||
| /** | |||
| * Finds the most specific directly matched CSS font-size rule from the list. | |||
| * | |||
| * @param {Array<LH.Crdp.CSS.RuleMatch>} [matchedCSSRules] | |||
| * @param {Array<LH.Crdp.CSS.RuleMatch>|undefined} matchedCSSRules | |||
There was a problem hiding this comment.
drive by fix, vscode flags this as a ts error
| @@ -346,7 +348,6 @@ class ImageElements extends Gatherer { | |||
| // or it's not in the top 50 largest images. | |||
| if ( | |||
| (element.isPicture || element.isCss || element.srcset) && | |||
| networkRecord && | |||
There was a problem hiding this comment.
confusion fix, we always default networkRecord to {} if we couldn't find one so this check does nothing
patrickhulce
commented
Sep 18, 2020
| @@ -188,6 +188,13 @@ class Server { | |||
| } | |||
|
|
|||
| function sendRedirect(url) { | |||
| if (url.split('').some(char => char.charCodeAt(0) > 256)) { | |||
There was a problem hiding this comment.
only semi-related, at one point debugging I put a redirect that contained non-ascii characters and it crashed the server entirely, which is suboptimal. returning a 500 makes more sense :)
patrickhulce
commented
Sep 18, 2020
paulirish
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A band-aid for #11450 to not set the natural dimensions if they were from a situation we know to provide incorrect natural dimensions. A proper fix for using the correct dimensions requires a much broader fixes across LH in #11454.
Related Issues/PRs
fixes #11450