-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): add lighthouse-batch-parallel to related projects #10385
Conversation
thanks for the PR @Carr1005 and great project! (love those docs too 😍) lately though we've been recommending against running multiple LH runs in parallel unless you have particularly beefy setups, do you think we could get some sort of disclaimer like that around the performance results in your project since it makes it so much easier to do now? :) |
@patrickhulce, thanks for the review! It's so lame that I just made a tool that is completely built by a not recommended way (with a very loud name 😂) I already put the disclaimer in my project, though now I am not sure if this is valuable to be added (as a tool to prove how wrong it can be 😂?) I am down for just closing this pr, maybe I'll simplify it and provide a new one without the feature of multiple monitoring in parallel and make another pr here at some points :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, no worries @Carr1005 it's a common enough request that I think having a project like this that explains how to do parallel requests responsibly and what to expect is still an added bonus :)
There are legit use cases for parallel lighthouse that don't involve performance metrics, so if you're primarily interested in the other categories it has a lot of value! 👍
…wed performance results Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
@patrickhulce, Thanks for the support! 🙌 |
Summary
This PR adds lighthouse-batch-parallel to the list of related projects!