Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add lighthouse-batch-parallel to related projects #10385

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

Carr1005
Copy link
Contributor

@Carr1005 Carr1005 commented Feb 26, 2020

Summary

This PR adds lighthouse-batch-parallel to the list of related projects!

@patrickhulce
Copy link
Collaborator

patrickhulce commented Feb 27, 2020

thanks for the PR @Carr1005 and great project! (love those docs too 😍)

lately though we've been recommending against running multiple LH runs in parallel unless you have particularly beefy setups, do you think we could get some sort of disclaimer like that around the performance results in your project since it makes it so much easier to do now? :)

@patrickhulce patrickhulce self-assigned this Feb 27, 2020
Carr1005 added a commit to Carr1005/lighthouse-batch-parallel that referenced this pull request Feb 28, 2020
@Carr1005
Copy link
Contributor Author

Carr1005 commented Feb 28, 2020

@patrickhulce, thanks for the review! It's so lame that I just made a tool that is completely built by a not recommended way (with a very loud name 😂) I already put the disclaimer in my project, though now I am not sure if this is valuable to be added (as a tool to prove how wrong it can be 😂?)

I am down for just closing this pr, maybe I'll simplify it and provide a new one without the feature of multiple monitoring in parallel and make another pr here at some points :)

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, no worries @Carr1005 it's a common enough request that I think having a project like this that explains how to do parallel requests responsibly and what to expect is still an added bonus :)

There are legit use cases for parallel lighthouse that don't involve performance metrics, so if you're primarily interested in the other categories it has a lot of value! 👍

readme.md Outdated Show resolved Hide resolved
…wed performance results

Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
@Carr1005
Copy link
Contributor Author

@patrickhulce, Thanks for the support! 🙌

@patrickhulce patrickhulce merged commit 00a33c0 into GoogleChrome:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants