This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Document device sleep and persistence behaviour of alarms API #7776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Preview (static) for commit 29f962f available at https://pr-7776-static-dot-dcc-staging.uc.r.appspot.com/. The following pages likely changed with this PR: |
AmySteam
reviewed
Nov 13, 2023
sebastianbenz
approved these changes
Nov 13, 2023
AmySteam
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great additions! I made a suggestion that would be good to apply before merging. I'm approving nevertheless to not be a blocker
Co-authored-by: amysteamdev <37001393+AmySteam@users.noreply.github.com>
sebastianbenz
pushed a commit
to sebastianbenz/developer.chrome.com
that referenced
this pull request
Nov 14, 2023
…Chrome#7776) * Document device sleep and persistence behaviour of alarms API * Address feedback * Add example code * Update site/en/docs/extensions/reference/alarms/index.md Co-authored-by: amysteamdev <37001393+AmySteam@users.noreply.github.com> --------- Co-authored-by: amysteamdev <37001393+AmySteam@users.noreply.github.com>
sebastianbenz
pushed a commit
to sebastianbenz/developer.chrome.com
that referenced
this pull request
Nov 14, 2023
…Chrome#7776) * Document device sleep and persistence behaviour of alarms API * Address feedback * Add example code * Update site/en/docs/extensions/reference/alarms/index.md Co-authored-by: amysteamdev <37001393+AmySteam@users.noreply.github.com> --------- Co-authored-by: amysteamdev <37001393+AmySteam@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some documentation on more nuanced behaviour in the
chrome.alarms
API.The wording here is quite vague but unfortunately I think it's the best we can do at the moment. There are several open issues around the behaviour we are close to resolving but which are still open:
While we could wait for those to be resolved, I think it's important we at least document the current behaviour since this is a heavily used API and the fixes may take time.
Fixes https://github.com/GoogleChromeLabs/Extension-Docs/issues/167