Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow statusListener to accept node instance instead of id #19

Merged
merged 2 commits into from
Feb 23, 2025

Conversation

GogoVega
Copy link
Owner

With the id addStatusListener needs to use setImmediate to set the status because at the time of the call the node has not yet been added to the API.

With this PR addStatusListener will be able to directly call node.status and avoid overwriting the current status of the node. e.g Permission Denied for Firebase and Firestore IN nodes.

Note: in a future PR, statusListener will no longer call node.status directly but an equivalent of node.setStatus. So that the status can be ignored (locally) if the node has a persistent status.

@GogoVega GogoVega merged commit 294fccc into master Feb 23, 2025
5 checks passed
@GogoVega GogoVega deleted the improvement/statusListener branch February 23, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant