Allow statusListener
to accept node instance instead of id
#19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the id
addStatusListener
needs to usesetImmediate
to set the status because at the time of the call the node has not yet been added to the API.With this PR
addStatusListener
will be able to directly callnode.status
and avoid overwriting the current status of the node. e.gPermission Denied
for Firebase and Firestore IN nodes.Note: in a future PR,
statusListener
will no longer callnode.status
directly but an equivalent ofnode.setStatus
. So that the status can be ignored (locally) if the node has a persistent status.