[DRAFT] Update for Android library changes in Godot 4.4-beta4 (unreleased) #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2025
2b37463 to
4eeaa32
Compare
m4gr3d
reviewed
Feb 12, 2025
Comment on lines
+63
to
+65
| override fun getCommandLine(): MutableList<String> { | ||
| // Force XR to be turned off. | ||
| return mutableListOf("--xr_mode_regular", "--xr-mode", "off") |
There was a problem hiding this comment.
We'd want to append to the parent command line arguments to ensure we don't inadvertently break some features. If there is conflicts with the arguments we're adding, we should remove the conflicting arguments and keep the rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes necessary to make hybrid apps compile and work with the (not-yet-committed) Godot PR godotengine/godot#102669.
It's built on top of #264, with the assumption that we'll merge that soon so our CI will work and we can resume other stuff, and that this PR will be merged after 4.4-beta4 releases (with the changes from godotengine/godot#102669)