-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ options for game version validation #536
Merged
KANAjetzt
merged 25 commits into
GodotModding:4.x
from
KANAjetzt:feat_setting-to-disable-version-check-or-use-custom-one
Feb 6, 2025
Merged
feat: ✨ options for game version validation #536
KANAjetzt
merged 25 commits into
GodotModding:4.x
from
KANAjetzt:feat_setting-to-disable-version-check-or-use-custom-one
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3a9e12
to
8a19d72
Compare
Qubus0
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a little weird, but it's certainly way better than not having it at all 😄
for easier testing
moved to docs page
Qubus0
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks ✨
Co-authored-by: steen <steen.rickmer@gmx.de>
KANAjetzt
commented
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Options
Game Version Validation
Choose between:
Customize Script Path
To apply settings that cannot be configured through the editor UI.
Currently, it is required for custom game version validation.
The custom validation uses
custom_game_version_validation_callable
aCallable
stored in theml_options
.I added an example script here:
https://github.com/KANAjetzt/godot-mod-loader/blob/feat_setting-to-disable-version-check-or-use-custom-one/addons/mod_loader/options/example_customize_script.gd
I'm open to suggestions or alternative solutions that require less setup work.