Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ options for game version validation #536

Conversation

KANAjetzt
Copy link
Member

@KANAjetzt KANAjetzt commented Jan 31, 2025

New Options

Game Version Validation

enum VERSION_VALIDATION {
   DEFAULT,
   DISABLED,
   CUSTOM,
}

Choose between:

  • DEFAULT: Uses standard semantic versioning (semver) validation.
  • DISABLED: Completely disables version validation.
  • CUSTOM: Allows for custom validation logic.

Customize Script Path

@export_file var customize_script_path: String

To apply settings that cannot be configured through the editor UI.

Currently, it is required for custom game version validation.
The custom validation uses custom_game_version_validation_callable a Callable stored in the ml_options.

I added an example script here:
https://github.com/KANAjetzt/godot-mod-loader/blob/feat_setting-to-disable-version-check-or-use-custom-one/addons/mod_loader/options/example_customize_script.gd

I'm open to suggestions or alternative solutions that require less setup work.

@KANAjetzt KANAjetzt added enhancement New feature or request validation Feature to make things safe and predictable 4.x labels Jan 31, 2025
@KANAjetzt KANAjetzt added this to the 4.x - 7.0.0 milestone Jan 31, 2025
@KANAjetzt KANAjetzt self-assigned this Jan 31, 2025
@KANAjetzt KANAjetzt force-pushed the feat_setting-to-disable-version-check-or-use-custom-one branch from b3a9e12 to 8a19d72 Compare February 2, 2025 09:26
@KANAjetzt KANAjetzt marked this pull request as ready for review February 2, 2025 19:32
@KANAjetzt KANAjetzt requested a review from Qubus0 February 2, 2025 19:32
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a little weird, but it's certainly way better than not having it at all 😄

addons/mod_loader/resources/options_profile.gd Outdated Show resolved Hide resolved
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks ✨

addons/mod_loader/resources/options_profile.gd Outdated Show resolved Hide resolved
addons/mod_loader/resources/options_profile.gd Outdated Show resolved Hide resolved
Co-authored-by: steen <steen.rickmer@gmx.de>
@KANAjetzt KANAjetzt added this pull request to the merge queue Feb 6, 2025
Merged via the queue into GodotModding:4.x with commit 6119166 Feb 6, 2025
1 check passed
@KANAjetzt KANAjetzt deleted the feat_setting-to-disable-version-check-or-use-custom-one branch February 6, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x enhancement New feature or request validation Feature to make things safe and predictable
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants