feat: Add rename_profile() to ModLoaderUserProfile
#352
Conversation
rename_profile() to ModLoaderUserProfile
|
@KANAjetzt Thank you very much for your review, now I think I have corrected the changes the way you suggested. Question for "running modloader in godot" do I need to take the mod developer route to test it? |
|
For starters, you can create an empty Godot Project and follow the steps on this page. If you get this working, you can look into symlinking the That will allow you to edit the code inside Godot, where you will get some syntax errors to fix. If no compile errors show up anymore, you can look into the mod developer route and add the rename functionality to the example user profile UI mod. This would be ideal, but it might be a bit overwhelming if you've never used Godot. So feel free to just edit your code inside Godot to get the syntax error messages, and I will review your code again. |
|
Hi @KANAjetzt sorry that it took so long, i corrected some changes as I am able to get the syntax error now |
|
Thank you again :) I'm sorry I don't have the chance yet to really dive deep into it.. |
only exported properties are duplicated
|
Mostly because the props only get duplicated if they are exported.
|
* Added method to rename user profile * Corrected functional changes and indentation from review * Indentation * Corrected false indentation and error * Corrected false indentation and error * Updated some failed changes * refactor: ♻️ export props only exported properties are duplicated * refactor: 🔥 remove vars * fix: 🐛 wrong user_profiles ref --------- Co-authored-by: Kai <kai@kana.jetzt>
# Minor Release v6.3.0 Minor update to fix issues with script extension sorting, as well as potential issues with translations, configurations, and user profiles. ## Key PRs - #357 - #358 - #520 - #352 ## Change Log ### New Features - #352 - #358 ### Fixes - #357 - #520 - #522 - #523 - #524 ### Refactors - #521 - #526 ### Tests - #360 ### Miscellaneous - #525 - #527 - #529
closes #287
Hi, for this change I modified and reference myself to method create_profile as @KANAjetzt in https://github.com/GodotModding/godot-mod-loader/blob/development/addons/mod_loader/api/profile.gd :)