Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ResourceLoader.exists() to prevent ERROR: A critical file is missing: res://addons/mod_loader/options/options.tres #481

Closed
KANAjetzt opened this issue Dec 5, 2024 · 1 comment
Closed

use ResourceLoader.exists() to prevent ERROR: A critical file is missing: res://addons/mod_loader/options/options.tres #481

KANAjetzt opened this issue Dec 5, 2024 · 1 comment
Labels
4.x bug Something isn't working
Milestone
4.x - 7.0.0

Comments

@KANAjetzt
Copy link
Member

godot-mod-loader/addons/mod_loader/mod_loader_store.gd

Lines 152 to 154 in 1bac6f6

# Get user options for ModLoader
if not _ModLoaderFile.file_exists(ml_options_path):
ModLoaderLog.fatal(str("A critical file is missing: ", ml_options_path), LOG_NAME)

https://docs.godotengine.org/en/stable/classes/class_resourceloader.html#class-resourceloader-method-exists
@KANAjetzt KANAjetzt added bug Something isn't working 4.x labels Dec 5, 2024
@KANAjetzt KANAjetzt added this to the 4.x - 7.0.0 milestone Dec 5, 2024
KANAjetzt added a commit to KANAjetzt/godot-mod-loader that referenced this issue Dec 5, 2024
@KANAjetzt
fix: 🐛 Take resource remapping into account
deb8c81 
added `ResourceLoader.exists()` to `_ModLoaderFile.file_exists()`

closes GodotModding#481
@KANAjetzt KANAjetzt mentioned this issue Dec 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2024
@KANAjetzt
fix: 🐛 Take resource remapping into account (#482)
b18acd9 
added `ResourceLoader.exists()` to `_ModLoaderFile.file_exists()`

closes #481
@KANAjetzt
Copy link
Member Author

KANAjetzt commented Dec 7, 2024 •
edited
Loading

closed by #482

@KANAjetzt KANAjetzt mentioned this issue Dec 7, 2024
Closed
KANAjetzt added a commit to KANAjetzt/godot-mod-loader that referenced this issue Jan 25, 2025
@KANAjetzt
fix: 🐛 Take resource remapping into account (GodotModding#482)
01d27f0 
added `ResourceLoader.exists()` to `_ModLoaderFile.file_exists()`

closes GodotModding#481
github-merge-queue bot pushed a commit that referenced this issue Jan 26, 2025
@KANAjetzt
fix: 🐛 Take resource remapping into account (#524)
24e7295 
fix: 🐛 Take resource remapping into account (#482)

added `ResourceLoader.exists()` to `_ModLoaderFile.file_exists()`

closes #481
KANAjetzt added a commit that referenced this issue Jan 26, 2025
@KANAjetzt
fix: 🐛 Take resource remapping into account (#524)
c74152b 
fix: 🐛 Take resource remapping into account (#482)

added `ResourceLoader.exists()` to `_ModLoaderFile.file_exists()`

closes #481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x bug Something isn't working
Projects
None yet
Milestone
4.x - 7.0.0
Development

No branches or pull requests
1 participant
@KANAjetzt