Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented support for selecting multiple packages for installation #611

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

igor84
Copy link
Collaborator

@igor84 igor84 commented Dec 25, 2023

image image

@igor84 igor84 requested review from JoC0de and popara96 December 25, 2023 11:49
Copy link
Collaborator

@JoC0de JoC0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay
looks good to me 👍
only one small note (can be ignored)


EditorGUI.LabelField(rectangle, string.Empty, headerStyle);

var arrow = showPackagesToInstall ? "\u2227" : "\u2228";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have used some constants for the string so we don't have "magic numbers"

@igor84
Copy link
Collaborator Author

igor84 commented Jan 3, 2024

I realized I didn't properly handle packages that are already installed or are available in Unity in the selection code so I fixed that. I also added a "Select all from clipboard" button so users can copy a list of package ids they need to install from somewhere and just click this button to have them all selected for installation.

@igor84 igor84 merged commit 7388d28 into master Jan 10, 2024
8 checks passed
@popara96 popara96 deleted the install-selection branch January 16, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants