Fix Invalid File Path Characters in Cached Image Hashing #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alid file path characters - Replaced the Base64 encoding method in GetHash with a hexadecimal conversion to ensure the generated hash string does not contain invalid characters for file paths on macOS and Windows. - This resolves issues with caching images on disk where the Base64-encoded hash could produce file paths with invalid characters.
|
Hi @robrab2000 |
|
Hey, yeah it was the '/' that was giving troubles :) |
JoC0de
requested changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the caching of images where the Base64-encoded hash could produce file paths with invalid characters. The issue was discovered while using an Apple Silicon based MacBook Pro running macOS Ventura (13.5.1) and Unity3d 2021.3.22f1.
Changes made:
GetHashmethod to convert the MD5 hash from Base64 encoding to a hexadecimal string. This ensures the generated hash string does not contain invalid characters for file paths.GetHashmethod.These changes resolve caching issues on disk and ensure compatibility across different operating systems.