-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling installing dependencies on restore #518
Conversation
Hi @tete1030 thanks for your contribution. |
I agree that it's a workaround for the You can try the To reproduce, first add some script with |
Do you need further information on this problem? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just was busy. So here my review. It would be nice if you also add the new feature to the documentation (Readme.md
).
Thanks for your review. I will update these and the doc. Regarding |
Can I bump this? |
@ConroyG OK so there is more demand. I will try to fix the last small thinks and merge the feature on the weekend. |
…GetForUnity into feature/lockpackages
Sorry that I forgot to follow through this PR. Really appreciate the merge. |
NugetForUnity is constantly adding and installing a package, which was explicitly deleted from packages.config, when opening Unity Editor after initial clone. This package (
System.Threading.Tasks.Extensions
) is a dependency of another. It has duplicated definition ofValueTask
class with netstandard. Deleting the package is thus necessary and has not caused any issue for me, so I have adopted this solution.I think respecting instead of updating
packages.config
when restoring is a reasonable case. For this reason I added an optionLock packages on restore
to disable installing dependencies of a restoring package.I also added a timeout option for nuget mirror requests. We have used customized nuget proxy with longer http request than usual (almost 20s).
Result: