New feature - selection #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor84
requested changes
Apr 8, 2023
JoC0de
reviewed
Apr 8, 2023
JoC0de
requested changes
Apr 8, 2023
- selection now works directly on existing "update" and "installed" packages, taking advantage of the "IsSelected" property of the package. This way, NugetHelper class should stay virtually untouched. - introduced some minor QoL changes: "Refresh" and "Preferences" buttons are now consistent, being drawn in the upper left on every tab; Search bar now doesn't have the "Search" button in "Installed" and "Updates" tabs - instead, every key stroke refreshes the filtered packages (it's a start for mentioned UX changes needed to improve the "Online" tab).
igor84
reviewed
Apr 21, 2023
igor84
reviewed
Apr 21, 2023
igor84
reviewed
Apr 21, 2023
JoC0de
reviewed
Apr 22, 2023
|
Small note about the most recent commit: IsSelected was removed when I merged master into select_packages branch, as I decided to resolve it that way because I was planning to remove the flag in the coming change. |
igor84
reviewed
Apr 23, 2023
JoC0de
reviewed
Apr 23, 2023
JoC0de
reviewed
Apr 23, 2023
|
@popara96 I now like it much more. Are there still thinks you need to work on? Only think I see is you need to fix the UnitTest*s. |
|
@JoC0de I'll fix the unit tests theses days when I have time, probably tomorrow. As for what I need to work on, I'd like to do similar thing for 'Online' tab but I will probably do it in a separate PR because there might be additional changes in order to do it. |
JoC0de
reviewed
May 3, 2023
JoC0de
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to select packages that the user wants to uninstall or update (instead of uninstalling/updating all). Also added an option to uninstall all packages.