Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roslyn analyzer package support #393

Merged
merged 8 commits into from
Jan 7, 2023

Conversation

nowsprinting
Copy link
Contributor

Roslyn analyzers supported on Unity 2020.2 or later.

The analyzer needs to make the following settings in plugin import settings.

  • Off all platforms
  • Set label RoslynAnalyzer

With this setting, it will be enabled as an analyzer in Unity 2020.2 or later, and enabled in generated .csproj by the following plugins.

  • JetBrains Rider Editor v2.0.6+
  • Visual Studio Code Editor v1.2.0+

see more information
https://docs.unity3d.com/2020.2/Documentation/Manual/roslyn-analyzers.html

Roslyn analyzers supported on Unity 2020.2 or later.

The analyzer needs to make the following settings in plugin import settings.
- Off all platforms
- Set label `RoslynAnalyzer`

With this setting, it will be enabled as an analyzer in Unity 2020.2 or later, and enabled in generated .csproj by the following plugins.
- JetBrains Rider Editor v2.0.6+
- Visual Studio Code Editor v1.2.0+

see more information
https://docs.unity3d.com/2020.2/Documentation/Manual/roslyn-analyzers.html
@nowsprinting
Copy link
Contributor Author

@robin-moss Thank you for your suggestions.

@JoC0de JoC0de force-pushed the roslyn_analyzer_support branch from 1191021 to e3007e2 Compare January 1, 2023 20:50
@JoC0de JoC0de force-pushed the roslyn_analyzer_support branch 3 times, most recently from 5577ed7 to f50368c Compare January 7, 2023 18:32
@JoC0de JoC0de force-pushed the roslyn_analyzer_support branch from f50368c to 2556bfc Compare January 7, 2023 20:22
@JoC0de
Copy link
Collaborator

JoC0de commented Jan 7, 2023

I was able to improve the implementation using a combination of your (@nowsprinting) code and things @robin-moss done in #14
So I am happy with the solution and how it works so I will merge it.
So @nowsprinting Thank you for the PR.
and @robin-moss Thank you for the "improvements".

@JoC0de JoC0de merged commit 1a6b486 into GlitchEnzo:master Jan 7, 2023
@nowsprinting nowsprinting deleted the roslyn_analyzer_support branch January 8, 2023 00:27
@JoC0de JoC0de mentioned this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants