Merge pull request #488 from JoC0de/feature/resolve-deprecated-code

Resolve deprecated code warnings
GlitchEnzo · Jan 21, 2023 · 67b7551 · 67b7551
2 parents ba92e12 + 6254c6e
commit 67b7551
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/src/NuGetForUnity/Editor/NugetPreferences.cs b/src/NuGetForUnity/Editor/NugetPreferences.cs
@@ -6,7 +6,7 @@ namespace NugetForUnity
     /// <summary>
     ///     Handles the displaying, editing, and saving of the preferences for NuGet For Unity.
     /// </summary>
-    public static class NugetPreferences
+    public class NugetPreferences : SettingsProvider
     {
         /// <summary>
         ///     The current version of NuGet for Unity.
@@ -18,11 +18,28 @@ public static class NugetPreferences
         /// </summary>
         private static Vector2 scrollPosition;
 
+        /// <summary>
+        ///     Instantiate the settings provider.
+        /// </summary>
+        public NugetPreferences()
+            : base("Preferences/NuGet For Unity", SettingsScope.User)
+        {
+        }
+
+        /// <summary>
+        ///     Creates a instance of the NuGet for Unity settings provider.
+        /// </summary>
+        /// <returns>The instance of the settings provider.</returns>
+        [SettingsProvider]
+        public static SettingsProvider Create()
+        {
+            return new NugetPreferences();
+        }
+
         /// <summary>
         ///     Draws the preferences GUI inside the Unity preferences window in the Editor.
         /// </summary>
-        [PreferenceItem("NuGet For Unity")]
-        public static void PreferencesGUI()
+        public override void OnGUI(string searchContext)
         {
             var preferencesChangedThisFrame = false;
 

diff --git a/src/NuGetForUnity/Editor/NugetWindow.cs b/src/NuGetForUnity/Editor/NugetWindow.cs
@@ -190,7 +190,7 @@ protected static void CheckForUpdates()
                     string latestVersion = null;
                     string latestVersionDownloadUrl = null;
                     string response = null;
-                    if (!request.isNetworkError && !request.isHttpError)
+                    if (string.IsNullOrEmpty(request.error))
                     {
                         response = request.downloadHandler.text;
                     }
@@ -327,7 +327,7 @@ private void Refresh(bool forceFullRefresh)
             }
             catch (Exception e)
             {
-                Debug.LogErrorFormat("Error while refreshing NuGet packages list: {0}", e.ToString());
+                Debug.LogErrorFormat("Error while refreshing NuGet packages list: {0}", e);
             }
             finally
             {