Change xy2ij behaviour to consider AREA_OR_POINT attribute as interpretation
#348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rify the use of AREA_OR_POINT
adehecq
reviewed
Feb 9, 2023
adehecq
requested changes
Feb 9, 2023
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
xy2ijso that it never shifts the coordinates of pixels based onself.tags['AREA_OR_POINT']by default. Now,ij2xyandxy2ijare reversible.Shifting with the interpretation of
self.tags['AREA_OR_POINT']remains a possibility however (as it could be needed during interpolation of points, for instance), and is performed by setting theshift_area_or_pixelasTrue(which then reads the attribute fromself.tags).Some tests added also.
Resolves #341