Upgrade pre-commit
#325
Merged
Upgrade pre-commit
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR ready to merge |
adehecq
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
I believe there is a way to automate this with a bot. In another repo that I copied from a template, there was such an action (which I found annoying there and hence deleted). It's here: adehecq/ragmac_xdem@81c9ad6.
But in the meantime, we're good with this one !
|
Merging this, as it may solve the CI error in PR #326. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current build is not passing because of
pre-commitissues that arose since CI last run for #321 (sometime in the last two weeks).This PR solves those by upgrading packages, and also adding the black profile to
isort.After the upgrade, there is only two new mypy errors related to
__init__calls used ingeovector. Those are not crucial (related to potential subclassing), so they are ignored for now.