Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecate version check #320

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Fix deprecate version check #320

merged 2 commits into from
Sep 26, 2022

Conversation

rhugonnet
Copy link
Member

Fix version check in our deprecate decorator using packaging.Version

Didn't realize this what also an issue in misc.py when solving #315

@rhugonnet
Copy link
Member Author

Same as previous PR on this, so I merge

@rhugonnet rhugonnet merged commit 4109bdb into GlacioHack:main Sep 26, 2022
@rhugonnet rhugonnet deleted the fix_testdeprecate branch September 26, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rhugonnet