Remove yaml method for diff calculation of environment.yml and dev-env.yml
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adehecq
reviewed
Sep 6, 2022
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff of environment files can be done more easily directly in conda, following @adehecq's comment in #297
However, we lose one thing when using conda compared to the previous PR: we do not test anymore if there are dependencies listed in
environment.ymlthat are not indicated indev-environment.yml.I have thus moved the function previously coded in
misc.pyintotest_misc.py, and it will run during the test suite to verify that we have written theenvironment.ymlanddev-environment.ymlcorrectly. Coding this was not for nothing! 😄