Set default resampling to bilinear instead of nearest in reproject #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fully agree. Maybe it should only be "nearest" when the dtype is boolean? |
rhugonnet
approved these changes
Aug 12, 2022
Yes I agree, but boolean types do not exist with GTiff, so there's no need for that specific case. Anyway, bilinear would yield the same result, it would just be longer... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think 'nearest' should not be the default resampling algorithm in reproject. For non integer warping, it will create artificial shifts between the two rasters.
Bilinear is the safest option as it is relatively fast, preserves range and will have an effect even for subpixel shifts.
Any thought against that?