Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1389 - Add back support for dot-delimited GitVersion outputs/variables #1394

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

arturcic
Copy link
Member

Closes #1389.

This PR adds back the dot-delimited GitVersion outputs/variables, but will be removed in the next major version.

Expanded the tool to set dot-delimited (`GitVersion.Property`) outputs and variables alongside existing formats. Updated corresponding tests to validate the new format for both outputs and environment variables, ensuring consistency and proper coverage.
@arturcic arturcic added this to the v3.1.1 milestone Dec 10, 2024
@arturcic arturcic merged commit 26a89e5 into GitTools:main Dec 10, 2024
13 checks passed
@arturcic arturcic deleted the fix/1389 branch December 10, 2024 15:17
Copy link
Contributor

mergify bot commented Dec 10, 2024

Thank you @arturcic for your contribution!

@arturcic arturcic added the bug Something isn't working label Dec 10, 2024
@gittools-bot
Copy link

🎉 This issue has been resolved in version v3.1.1 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

@WilliBarankin
Copy link

@arturcic Artur, thank you for your contribution!
Can somebody please point me to a document why dot-delimited vars should be removed?

@arturcic
Copy link
Member Author

arturcic commented Dec 10, 2024

@arturcic Artur, thank you for your contribution! Can somebody please point me to a document why dot-delimited vars should be removed?

There is not documented yet, but in v7 of GitVersion we might want to simplify the BuildAgents story, and have a simple .env or similar output that is then consumed by others. The reason for this change is we want to make it easier to support any BuildAgents out there that have different mechanism of using variables, but basically all of them are able to load environment variables, and also this should also simplify the codebase, but that is just something we're considering at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE]: Gittools Azure DevOps task 3.0.4 unable to retrieve gitversion output variables value or set version
3 participants