ToB chapter change in ar4000.bcs

[RoxanneSHS]

see this post for problem and suggested solution
http://gibberlings3.net/forums/index.php?showtopic=29295#entry259509

[RoxanneSHS]

PR #13 submitted

[K4thos]

Roxanne, I've noticed that BG2:EE received 2.5 patch for BG2:EE, so I've done a quick update that solves all installation warnings. I'd like to discuss your pull requests and internalize them within code, but it looks like G3 is offline, so I can't view the bugs descriptions.

[RoxanneSHS]

The bug report(s) about it are very similar. Some mod (latest example Almateria mod, other was Breagar but that is corrected meanwhile) adds some code to the top of the ar4000.bcs that triggers prior to the OnCreation() block that contains the chapter increment. The big OnCreation block is not executed, when you go to the bhaal plane you are still in chapter 19 (or 7 when you play without EET).
The effect in EET is more dramatic than in non-EET game because all the dialogue and PID triggers of NPCs use the chapterGT19 LT20 barrier.
My proposal was just a safety code block that would trigger even if the first one fails. The better solution of course would be NOT to use the garbage OnCreation() trigger for the big transition block, but I think this is somehow inherited from the original code. Bioware used OnCreation() a lot, not taking into account that modders would appear some day...

PS - here is one report that appeared on my own forum recently http://baldursextendedworld.com/Vanilla_Forums/discussion/20/pid-not-functioning-in-tob#latest

[K4thos]

So this was not a bug in EET after all. Thanks for investigating the issue. OnCreation() in that block is completly usless considering there is already Global("TurnDay","AR4000",0) and SetGlobal("TurnDay","AR4000",1) in the same block. It will be removed in the RC10 because that block is crucial for EET. And yes, OnCreation() is there in vanilla BG2:EE.