Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swipe won't work crome 62.0.3202 android 5.1.1 SM-J320F build/LMY47V #54

Closed
englishextra opened this issue Nov 21, 2017 · 6 comments
Closed

Comments

@englishextra
Copy link

englishextra commented Nov 21, 2017

But it works - Tocca.js 2.0.1 - on same android with firefox 57.0

But demo here detects events with Chrome 62.0.3202 fine

So yes some pages on my sites have:

html,
body {
	height: 100%;
}
body {
	width: 100%;
	overflow-x: hidden;

or

html,
body {
	height: 100%;
}
body {
	width: 100%;
	overflow-y: auto;

That's all that I had dug out.

testing page here https://englishextra.github.io/ - swipeup or swipedown

Important : the events are set to passive.

var mousewheeldown = document[getElementsByClassName]("mousewheeldown")[0] || "";
var swipeup = document[getElementsByClassName]("swipeup")[0] || "";
if (mousewheeldown && swipeup) {
	if (hasTouch) {
		mousewheeldown[style].display = "none";
		if (root.tocca) {
			root[_addEventListener]("swipeup", revealStart, {passive: true});
			root[_addEventListener]("swipedown", concealStart, {passive: true});
		}
	} else {
		if (hasWheel) {
			swipeup[style].display = "none";
			if (root.WheelIndicator) {
				var indicator;
				indicator = new WheelIndicator({
						elem: root,
						callback: function (e) {
							if ("down" === e.direction) {
								revealStart();
							}
							if ("up" === e.direction) {
								concealStart();
							}
						},
						preventMouse: false
					});
			}
		}
	}
	if (hasTouch || hasWheel) {
		guesture[classList].add(bounceInUpClass);
		guesture[style].display = "block";
	}
}

caniuse says android chrome 62 and webview 62 support passive listeners

Tocca.js 2.0.1 swipeup and swipedown works in chrome 49.2623.91 on android 6.0.1; P024 build/MMB29M

Doesnt work on my site with Opera 43.02246

@GianlucaGuarini
Copy link
Owner

fixed in v2.0.2

@englishextra
Copy link
Author

why would you close the issue. can you give me a day or two to test that fix?

@GianlucaGuarini
Copy link
Owner

sorry i guess i will need to reopen it. I am still unhappy with the current result.

@englishextra
Copy link
Author

@GianlucaGuarini First thing in the morning I can test that. Sorry but your lib is an imortant part in the logic of my apps - so any changes are sensitive.

GianlucaGuarini added a commit that referenced this issue Dec 29, 2017
@GianlucaGuarini
Copy link
Owner

ok now it should be fine. Please check your issue and close it if it was fixed

@englishextra
Copy link
Author

It works fine, very nice and thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants