Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-tap doesn't seem to work on KitKat Chrome or Safari iOS 8 #14

Closed
gtnewton opened this issue Feb 27, 2015 · 19 comments
Closed

Double-tap doesn't seem to work on KitKat Chrome or Safari iOS 8 #14

gtnewton opened this issue Feb 27, 2015 · 19 comments

Comments

@gtnewton
Copy link

Thanks for this lib. It's fabulous and I'm using it successfully in a couple projects. However, I recently wanted to add 'double-tap to go fullscreen' functinoality, but I've been unable to make dbltap work. I don't think it's just me: your demo does not seem to register double-taps either.
Thanks!

@GianlucaGuarini
Copy link
Owner

Are you sure the bug it's not in your app? Because from here everything works fine on android

@GianlucaGuarini
Copy link
Owner

Even if it's a bit small you should be able to see the event name="dbltap"
screen shot 2015-02-28 at 00 41 29

@gtnewton
Copy link
Author

Hm. Maybe I'm doing something wrong, but I don't think so. When I go here on my phone (Nexus 5, KitKat, Chrome, up-to-date) and double-tap I get 'Event Name tap'. I get the same response on an iPad (iOS 8) and a Nexus 7 (KitKat, up-to-date, etc.) and Chrome on my desktop machine (Chromium 40.0.2214.111).
I noticed your screenshot, but I don't get that 'dbltap'. It doesn't look like you're using KitKat, though. Perhaps that's the problem(?)

@GianlucaGuarini
Copy link
Owner

What if you increase this value DBL_TAP_THRESHOLD ?

@gtnewton
Copy link
Author

I just tried it on Firefox (on my phone), and it does work. I think this might be a KitKat/Chrome thing...
Oh, I did try increasing that threshold. No go.

@GianlucaGuarini
Copy link
Owner

I get the dbltap on the ipad as well
screen shot 2015-02-28 at 00 48 54

@gtnewton
Copy link
Author

The iPad I'm using is an iPad 3 (physical), running iOS 8.1.3.

@GianlucaGuarini
Copy link
Owner

Ok so It needs to be checked a bit better thanks for your bug report. Do you have the same problem on the old Toccajs (0.1.0) releases?

@gtnewton
Copy link
Author

Good question. I'll try it and let you know.

@gtnewton
Copy link
Author

Aha! It works on the iPad and my phone.

@GianlucaGuarini
Copy link
Owner

do you mean the old release?

@gtnewton
Copy link
Author

Sorry. Yes. I checked out 0.1.0 and it works on both devices.

@GianlucaGuarini
Copy link
Owner

Also on android 5 it works
screen shot 2015-02-28 at 01 08 48

I have tested old ipads android opera... and it works everywhere obviously on the emulators. I will check on monday in the office to see if the issue appears on the real devices

@gtnewton
Copy link
Author

OK. Thanks for the quick responses. I'm happy to test on the physical devices I have access to.

@gtnewton
Copy link
Author

gtnewton commented Mar 1, 2015

I just realized that I made a stupid mistake. I'm not using Android Kitkat anymore. I'm on Android Lollipop (5.0.1). And I see that you aren't saying that you support 5.0 yet. Sorry for the confusion. I can wait for Lollipop support if it isn't a current priority for you.

GianlucaGuarini added a commit that referenced this issue Mar 2, 2015
@GianlucaGuarini
Copy link
Owner

Could you please try the Tocca.js version available on this branch ?

@gtnewton
Copy link
Author

gtnewton commented Mar 2, 2015

That looks good! It registers dbltap on my Nexus 5, Nexus 7 and my iPad.

@GianlucaGuarini
Copy link
Owner

Awesome thanks for your help

@gtnewton
Copy link
Author

gtnewton commented Mar 2, 2015

No, thank you! That was fabulous. I really appreciate your effort. Cheers!

GianlucaGuarini added a commit that referenced this issue Mar 2, 2015
GianlucaGuarini added a commit that referenced this issue Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants