Fixed Villager Position when Sleeping #933
Merged
+64
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of these changes should be moved to |
|
It may be worth testing if there is a Java edge case where other entities sleep. Otherwise, I agree. |
|
I don't think any other entity have the ability to sleep. I will move the changes to the VillagerEntity file |
rtm516
requested changes
Jul 11, 2020
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
Camotoy
previously requested changes
Jul 11, 2020
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
|
I believe that is all of the requested changes |
rtm516
previously requested changes
Jul 11, 2020
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/living/merchant/VillagerEntity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/living/merchant/VillagerEntity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/living/merchant/VillagerEntity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/living/merchant/VillagerEntity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/living/merchant/VillagerEntity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/living/merchant/VillagerEntity.java
Outdated
Show resolved
Hide resolved
Camotoy
reviewed
Jul 11, 2020
connector/src/main/java/org/geysermc/connector/entity/living/merchant/VillagerEntity.java
Show resolved
Hide resolved
|
Manually resolved some of the spacing and indentation problems. Thanks for your contribution! |
Redned235
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edits the position of a villager with the tag SLEEPING and will set it to the direction of the bed
This is my first Pull Request and I am also new to Java so forgive me for any mistakes