1.16.210 support #2019
Merged
1.16.210 support #2019
+450
−250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ktranslatorrefactor
Fix block inventories
rtm516
requested changes
Mar 9, 2021
connector/src/main/java/org/geysermc/connector/network/BedrockProtocol.java
Outdated
Show resolved
Hide resolved
Comment on lines
+74
to
+76
| // Set the block translation based off of version | ||
| session.setBlockTranslator(packetCodec.getProtocolVersion() >= Bedrock_v428.V428_CODEC.getProtocolVersion() | ||
| ? BlockTranslator1_16_210.INSTANCE : BlockTranslator1_16_100.INSTANCE); |
There was a problem hiding this comment.
I feel like if we expand this it should be implemented as part of the BedrockProtocol class. But that's out of scope for this PR.
...ector/src/main/java/org/geysermc/connector/network/translators/world/chunk/BlockStorage.java
Outdated
Show resolved
Hide resolved
...ector/src/main/java/org/geysermc/connector/network/translators/world/chunk/ChunkSection.java
Outdated
Show resolved
Hide resolved
…tors/world/chunk/ChunkSection.java Co-authored-by: rtm516 <rtm516@users.noreply.github.com>
rtm516
approved these changes
Mar 9, 2021
Chew
pushed a commit
to Chew/Geyser
that referenced
this pull request
Mar 10, 2021
This commit implements 1.16.210 support while still keeping 1.16.100 and 1.16.210 compatibility. Co-authored-by: AJ Ferguson <AJ-Ferguson@users.noreply.github.com> Co-authored-by: rtm516 <rtm516@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.