Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when link entity not found and use non-deprecated constructor #1706

Merged
merged 5 commits into from
Jan 28, 2021
Merged

Fix NPE when link entity not found and use non-deprecated constructor #1706

merged 5 commits into from
Jan 28, 2021
+4 −1

Conversation

rtm516
Copy link
Member

@rtm516 rtm516 commented Dec 18, 2020 •
edited
Loading

This fixes an issue found through the public GeyserConnect instance.

2020-12-17 09:15:28.700 [Thread-263] E - �[31;1mCould not translate packet ServerSpawnPlayerPacket�[0m
java.lang.NullPointerException: null
    at org.geysermc.connector.entity.player.PlayerEntity.spawnEntity(PlayerEntity.java:106) ~[GeyserConnect.jar:?]
    at org.geysermc.connector.entity.player.PlayerEntity.sendPlayer(PlayerEntity.java:123) ~[GeyserConnect.jar:?]
    at org.geysermc.connector.network.translators.java.entity.spawn.JavaSpawnPlayerTranslator.translate(JavaSpawnPlayerTranslator.java:64) ~[GeyserConnect.jar:?]
    at org.geysermc.connector.network.translators.java.entity.spawn.JavaSpawnPlayerTranslator.translate(JavaSpawnPlayerTranslator.java:38) ~[GeyserConnect.jar:?]
    at org.geysermc.connector.network.translators.PacketTranslatorRegistry.translate(PacketTranslatorRegistry.java:93) [GeyserConnect.jar:?]
    at org.geysermc.connector.network.session.GeyserSession$1.packetReceived(GeyserSession.java:540) [GeyserConnect.jar:?]
    at com.github.steveice10.packetlib.event.session.PacketReceivedEvent.call(PacketReceivedEvent.java:51) [GeyserConnect.jar:?]
    at com.github.steveice10.packetlib.tcp.TcpSession.callEvent(TcpSession.java:149) [GeyserConnect.jar:?]
    at com.github.steveice10.packetlib.tcp.TcpSession$3.run(TcpSession.java:324) [GeyserConnect.jar:?]
    at java.lang.Thread.run(Thread.java:748) [?:1.8.0_275]

@rtm516 rtm516 added the PR: Bugfix When a PR contains a bugfix label Dec 18, 2020
@rtm516 rtm516 added the PR: Needs Testing When a PR needs testing but is currently not under review label Dec 18, 2020
@Camotoy Camotoy mentioned this pull request Jan 25, 2021
Closed
@Camotoy Camotoy merged commit 498f765 into GeyserMC:master Jan 28, 2021
@LichLord91 LichLord91 mentioned this pull request Jan 28, 2021
Merged
@rtm516 rtm516 deleted the link-fix branch January 28, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camotoy Camotoy Camotoy approved these changes

Assignees
No one assigned
Labels
PR: Bugfix When a PR contains a bugfix PR: Needs Testing When a PR needs testing but is currently not under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtm516 @Camotoy