Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAProxy PROXY protocol support for downstream connections #1688

Merged
merged 5 commits into from
Dec 24, 2020
Merged

HAProxy PROXY protocol support for downstream connections #1688

merged 5 commits into from
Dec 24, 2020

Conversation

mikroskeem
Copy link
Contributor

@mikroskeem mikroskeem commented Dec 15, 2020

Addresses one half of #677 - allowing Geyser to connect to Velocity or BungeeCord with PROXY protocol enabled.

Checklist:

  • Get it working
  • Add configuration option
  • Upstream modified MCProtocolLib parts

@Camotoy
Copy link
Member

Camotoy commented Dec 15, 2020

I mentioned this on Discord but in case you missed it - this probably would be better upstream at MCProtocolLib, unless Steveice rejects it for some reason.

@mikroskeem mikroskeem marked this pull request as ready for review December 19, 2020 21:22
@mikroskeem
Copy link
Contributor Author

This PR should be now ready for final reviews and merging.

Copy link
Member

@Camotoy Camotoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I will get another review or two before this is merged.

connector/pom.xml Outdated Show resolved Hide resolved
@Camotoy Camotoy merged commit c67d919 into GeyserMC:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants