feat(hooks): add useCollectionQuery and useIsMounted [JOB-32207] #561
Conversation
|
✔️ Deploy Preview for jobber-atlantis ready! 🔨 Explore the source changes: 6cf99ec 🔍 Inspect the deploy log: https://app.netlify.com/sites/jobber-atlantis/deploys/60dce0ded4669c000763747c 😎 Browse the preview: https://deploy-preview-561--jobber-atlantis.netlify.app |
* useIsMounted DONE, useCollectionQuery DONE * ugly state of dependancies being updated to represent what is actually needed in atlantis * Fix typing on useCollectionQuery.ts * Add `useIsMounted` tests * Add specs for useCollectionQuery * Add back build * Add error notifier spec * Prettier fix * Check both nodes and edges * Ensure we're only looking at local `node_modules` for typing * Fix useCollecitonQuery mdx file * Export useIsMounted * Add `useIsMounted` mdx file * Prettier fix * Remove react from package file * Prettier fix * Prettier fix Co-authored-by: Andrew McCann <andrew.j.d.mccann@gmail.com>
…ounted Hooks [32207] (#575) * writing of the mdx files for useIsMounted and useCollectionQuery * PR feedback updates: cleanup, better descriptions, icon change * put fetch policies together * Make usIsMounted mdx less annoying * unused import
There was a problem hiding this comment.
This is looking really great! Thanks so much for everything here. I do have some pondering to do around the Rollbar and Config thing there but in the mean time have some thoughts back your way. If you have any questions or thoughts on them lemme know happy to chat! 😃
packages/hooks/src/useCollectionQuery/useCollectionQuery.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sean Healy <sean.h@getjobber.com>
|
@seanhealy Have you had a chance to think any more about the |
…y-to-atlantis' into JOB-32207/move-useCollectionQuery-to-atlantis
Motivations
useCollectionQuery and useIsMounted are both hooks that live within two repositories: Jobber Online and Jobber Mobile.
Moving them to Atlantis will allow for easier edits to the hooks, and easier maintenance of the tests.
Communiverse has already reviewed all of this in pieces as it was landing. We're just looking for final feedback from the McWeb team.
There is a known BUG within useCollectionQuery caused by Apollo. It has been fixed within their release candidate and a workaround solution PR will be up soon. The link to the issue can be found here: apollographql/apollo-client#7491 (comment)
Changes
Added
Configurationobject for the hooks library to configure things like Error ReportersChanged
Deprecated
Removed
Fixed
Security
Testing
http://localhost.test:3333/hooks/use-collection-query
4 items in the list
Fetch More loads 4 more
[ BUG IN USECOLLECTIONQUERY -- FIX PR coming soon ] Refresh will return all fetchedMore items.
http://localhost.test:3333/hooks/use-is-mounted
Clicking the appropriate buttons will unmount or mount the component. This is a dependancy of useCollecitonQuery
In Atlantis we use Github's built in pull request reviews.