Friendlier archive names, tarsnap errors #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) When using paths like /path/to/my/folder inside tarsnap.folders, tarsnap-generations will use that as $dir in the filename, which can cause issues because of slashes. Proposed method is to replace slashes with dots to keep filenames harmless. 2)Line 124, the exit $? exits with the status of the last echo, which is always 0. Better to store tarsnap's code and use it in that exit statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2)Line 124, the exit $? exits with the status of the last echo, which is always 0. Better to store tarsnap's code in an $errcode variable and use it in the exit statement.