Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #9

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Update #9

merged 9 commits into from
Mar 27, 2024

Conversation

jburel
Copy link
Contributor

@jburel jburel commented Mar 22, 2024

  • Add badges to readme
  • Fix hyperlink
  • Add flake8 check and fix error
  • Bump action version to avoid warnings

@Tom-TBT
Copy link
Member

Tom-TBT commented Mar 25, 2024

Thank you very much for the changes JM. I will transpose them to omero-tagsearch if you don't mind.

@jburel
Copy link
Contributor Author

jburel commented Mar 25, 2024

I was waiting for your work on tagsearch to be completed since it will probably conflict when enalbing flake8
Happy to do it
either way is fine

Copy link
Member

@Tom-TBT Tom-TBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again, everything looks good to me and I see no error on my test instance.
I will merge this if there's nothing else you want to add.

And thank you for offering to do the same for tagsearch, but I feel that I should be the one cleaning the repo. So I'll take care of that once the ongoing PR is merged.

@jburel
Copy link
Contributor Author

jburel commented Mar 27, 2024

No more changes from my side

@Tom-TBT Tom-TBT merged commit 97b7a7a into German-BioImaging:master Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants