Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr2 #210

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Pr2 #210

merged 1 commit into from
Mar 29, 2024

Conversation

nim65s
Copy link
Member

@nim65s nim65s commented Mar 28, 2024

this is #209, but with optimized pngs and squashed commits, plus loader & tests. Not sure why nq=41 and nv=36, though

@nim65s
Copy link
Member Author

nim65s commented Mar 28, 2024

Also, I'm not sure if we really need those normals or not. they are pretty big.

Copy link
Collaborator

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why merge this to the Gepetto:devel branch?

@florent-lamiraux
Copy link
Contributor

I removed the useless png files and force pushed to guilhem branch.

@florent-lamiraux florent-lamiraux merged commit 2d56e3d into Gepetto:devel Mar 29, 2024
1 of 2 checks passed
@nim65s
Copy link
Member Author

nim65s commented Mar 29, 2024

Why merge this to the Gepetto:devel branch?

Well, that's the devel branch of the main repository of this project, so I don't understand what is bothering you here

@nim65s nim65s deleted the pr2 branch March 29, 2024 10:39
nim65s added a commit to nim65s/robotpkg that referenced this pull request Dec 8, 2024
    ## [4.2.0] - 2024-12-08

    ### Added
    - Add PR2 robots ([210](Gepetto/example-robot-data#210))
    - Add GO2 robots ([239](Gepetto/example-robot-data#239))
    - Add Falcon Bravo7 Bluevolta robots ([244](Gepetto/example-robot-data#244))
    - Add alex robots ([247](Gepetto/example-robot-data#247))
    - Add compatibility with jrl-cmakemodules workspace ([225](Gepetto/example-robot-data#225))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants