Migrate2junit5 #478
Migrate2junit5 #478
Conversation
Hogajama/hogajama-domain/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter</artifactId> | ||
| <version>5.10.1</version> |
There was a problem hiding this comment.
Is there a reason, why the versions is not managed in the dependency-management section of the parent pom?
| public void setUpMethod() throws Exception { | ||
| Mockito.when(sensorCache.getByDeviceId(DEVICE_ID_NOTFOUND)).thenReturn(Optional.empty()); | ||
| Mockito.when(sensorCache.getByDeviceId(DEVICE_GRUENER_GEPARD)).thenReturn(TestSensors.sensorGruenerGepard()); | ||
| Mockito.lenient().when(sensorCache.getByDeviceId(DEVICE_ID_NOTFOUND)).thenReturn(Optional.empty()); |
There was a problem hiding this comment.
Lenient would not be necessary if we make two @nested Test-Classes for each type
- GruenerGepard
- DeviceIdNotFound
Then the Mocks could be done for each class seperately.
Hogajama/hogajama-rs/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter</artifactId> | ||
| <version>5.10.1</version> |
There was a problem hiding this comment.
Is there a reason, why the versions is not managed in the dependency-management section of the parent pom?
| @@ -61,7 +58,7 @@ public void testDateUtilTimeOK() { | |||
| public void testDateUtilTimeNOKHour() { | |||
| try { | |||
| DateUtil.getTime(99, 0, 0); | |||
| assertTrue("IllegalArgumentException was not thrown.", false); | |||
| assertTrue(false, "IllegalArgumentException was not thrown."); | |||
There was a problem hiding this comment.
Maybe we should use assertThrows for this test and the following. This would increase readability.
Hogajama/hogajama-services/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter</artifactId> | ||
| <version>5.10.1</version> |
There was a problem hiding this comment.
Is there a reason, why the versions is not managed in the dependency-management section of the parent pom?
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter</artifactId> | ||
| <version>5.10.1</version> |
There was a problem hiding this comment.
Is there a reason, why the versions is not managed in the dependency-management section of the parent pom?
|
Cleaned versions in POMs. |
|
|
Fixed Checks. |
Migrate Tests from JUnit 4 to 5 with OpenRewrite