-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filters #800
feat: filters #800
Conversation
I'll do the settings on this PR too I guess TODO:
I'm not sure about the layout :/ maybe the expander rows are a bit too much? (they still need padding ofc). Also I doubt there are keyword limits on all backends so I set it to only expand if there are at most 10 keywords. The edit dialog would still need to display all of them. Screencast.from.2024-02-24.22-45-53.webm |
Still so much to do but somewhat getting there. Not so fun fact, there are 0 limits on filters as far as I can tell. No keyword amount limit, not keyword length limit, no filter limit, no title length limit... 🤷 Screencast.from.2024-02-25.23-33-26.webm |
fix: #200
Filter settings should be split into a separate FRI'll do it here igThere's stuff I'm unsure about and stuff I'd rather hadn't added:
Screencast.from.2024-02-24.16-59-18.webm