Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Status): memory leak #799

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix(Status): memory leak #799

merged 1 commit into from
Feb 22, 2024

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Feb 22, 2024

as always, Vala lambda self ref

Statuses with a kind (like boosted) would stay in memory due to a lambda that would self-ref.

fix: #798 (might not fix everything but at least most of it)

Load -> Load another page -> Refresh

Screencast.from.2024-02-22.11-43-35.webm

as always, Vala lambda
@algernon
Copy link

I'll patch my Tuba and see how it fares overnight, will report my findings tomorrow morning!

@GeopJr GeopJr merged commit 0f72dbf into main Feb 22, 2024
6 checks passed
@GeopJr GeopJr deleted the fix/status/memory-leak branch February 22, 2024 17:21
@algernon
Copy link

(2024-02-22 15:00)
    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
3467494 algernon  20   0 3522364   1.2g 131976 S   0.0   3.7   3:08.63 .dev.geopjr.Tuba

(2024-02-22 22:00)
    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
3467494 algernon  20   0 5621632   2.9g 122488 S   0.0   9.3  26:22.68 .dev.geopjr.Tuba

(2024-02-23 07:00)
    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
3467494 algernon  20   0 5548196   3.0g 126380 S   0.0   9.4  35:21.60 .dev.geopjr.Tuba

This does, indeed, help a lot. Both Virt & Res are considerably lower. Still leaky, but about half as much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Long-running Tuba leaks memory
2 participants