Fix keyboard shortcuts in editor and media viewer #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter the Gdk.ModifierState value to exclude internal values when matching them against expected modifier state. This is necessary to make the key shortcuts work when Num Lock is on. Per GDK documentation: ``` * Note that GDK may add internal values to events which include values outside * of this enumeration. Your code should preserve and ignore them. You can use * %GDK_MODIFIER_MASK to remove all private values. ```
Add NumPad + (KP_Add) and - (KP_Subtract) keys to accepted keys for zoom in/out shortcuts, for better consistency and usability.
|
LGTM, thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed modifier checks not to be affected by NumLock (and other private GDK constants). Fixed MediaViewer and Composer to accept NumPad keys along with alphanumeric block keys.
Fixes #725