Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12455] Map thumbnails extent always cover the whole globe #12460

Merged
merged 7 commits into from
Sep 18, 2024

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Jul 30, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi added the backport 4.3.x backport to 4.3.x label Jul 30, 2024
@mattiagiupponi mattiagiupponi requested a review from giohappy July 30, 2024 12:38
@mattiagiupponi mattiagiupponi self-assigned this Jul 30, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 30, 2024
@mattiagiupponi mattiagiupponi added this to the 4.4.0 milestone Jul 30, 2024
@mattiagiupponi mattiagiupponi linked an issue Jul 30, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.15%. Comparing base (2e4dae2) to head (a52900d).
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12460      +/-   ##
==========================================
- Coverage   64.16%   64.15%   -0.01%     
==========================================
  Files         888      888              
  Lines       53465    53469       +4     
  Branches     6596     6598       +2     
==========================================
- Hits        34304    34303       -1     
+ Misses      17651    17649       -2     
- Partials     1510     1517       +7     

@mattiagiupponi mattiagiupponi requested a review from giohappy July 30, 2024 15:01
@mattiagiupponi mattiagiupponi marked this pull request as ready for review July 31, 2024 07:18
@giohappy
Copy link
Contributor

@mattiagiupponi the calculated box is wrong, as you can see from the thumbnail of this layer for Italy.

image

I also verified the extent coordinates reported inside the API response and they are actually wrong (consistent with the thumbnail area)

image

Copy link
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about wrong calculated extent

@mattiagiupponi mattiagiupponi added backport 4.4.x and removed backport 4.3.x backport to 4.3.x labels Sep 18, 2024
@giohappy giohappy self-requested a review September 18, 2024 10:36
@giohappy giohappy linked an issue Sep 18, 2024 that may be closed by this pull request
@giohappy giohappy merged commit 5bcbd82 into master Sep 18, 2024
15 checks passed
@giohappy giohappy deleted the ISSUE_12455 branch September 18, 2024 12:09
github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
…2460)

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* Fixed bbox calculation and repositioned utils

* [Fixes #12455] fix test

---------

Co-authored-by: G. Allegri <giohappy@gmail.com>
(cherry picked from commit 5bcbd82)
giohappy pushed a commit that referenced this pull request Sep 18, 2024
…2460) (#12588)

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* Fixed bbox calculation and repositioned utils

* [Fixes #12455] fix test

---------

Co-authored-by: G. Allegri <giohappy@gmail.com>
(cherry picked from commit 5bcbd82)

Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
@kikislater
Copy link
Contributor

@mattiagiupponi @giohappy thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.4.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map thumbnails extent always cover the whole globe Suspicious bounding box in maps
3 participants