Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove overridden of the project and siteRender to make AbstractReport work as expected #706

Conversation

omarmahamid
Copy link

@omarmahamid omarmahamid commented Jan 15, 2025

closes ##705

@mprins
Copy link
Member

mprins commented Jan 16, 2025

please use rebase to make your branch up-to-date and cleanup your commit history, this will hopefully trigger the CI actions as well

@mprins mprins requested a review from Copilot January 16, 2025 17:15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@omarmahamid
Copy link
Author

@mprins done.

@omarmahamid omarmahamid changed the title make it work with higher maven version remove overridden of the project and siteRender to make AbstractReport work as expected Jan 16, 2025
@mprins
Copy link
Member

mprins commented Jan 17, 2025

Closing in favour of #707 as this PR does not provide a testcase and the commit history was not cleaned up as requested

@mprins mprins closed this Jan 17, 2025
@GeoDienstenCentrum GeoDienstenCentrum locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants