Skip to content

Commit

Permalink
Update to sovrn custom params as well as site object construction (pr…
Browse files Browse the repository at this point in the history
…ebid#2149)

* fix sovrn dealid

* send 'iv' param if present

* `page` field in `site` object sends full url
  • Loading branch information
aprakash-sovrn authored and dluxemburg committed Jul 17, 2018
1 parent 5484803 commit 3391a5c
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 2 deletions.
6 changes: 5 additions & 1 deletion modules/sovrnBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ export const spec = {
*/
buildRequests: function(bidReqs) {
let sovrnImps = [];
let iv;
utils._each(bidReqs, function (bid) {
iv = iv || utils.getBidIdParameter('iv', bid.params);
sovrnImps.push({
id: bid.bidId,
banner: { w: 1, h: 1 },
Expand All @@ -36,9 +38,11 @@ export const spec = {
imp: sovrnImps,
site: {
domain: window.location.host,
page: window.location.pathname + location.search + location.hash
page: window.location.host + window.location.pathname + location.search + location.hash
}
};
if (iv) sovrnBidReq.iv = iv;

return {
method: 'POST',
url: `//ap.lijit.com/rtb/bid?src=${REPO_AND_VERSION}`,
Expand Down
22 changes: 21 additions & 1 deletion test/spec/modules/sovrnBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('sovrnBidAdapter', function() {
});

describe('buildRequests', () => {
let bidRequests = [{
const bidRequests = [{
'bidder': 'sovrn',
'params': {
'tagid': '403370'
Expand All @@ -63,6 +63,26 @@ describe('sovrnBidAdapter', function() {
it('attaches source and version to endpoint URL as query params', () => {
expect(request.url).to.equal(ENDPOINT)
});

it('sends \'iv\' as query param if present', () => {
const ivBidRequests = [{
'bidder': 'sovrn',
'params': {
'tagid': '403370',
'iv': 'vet'
},
'adUnitCode': 'adunit-code',
'sizes': [
[300, 250]
],
'bidId': '30b31c1838de1e',
'bidderRequestId': '22edbae2733bf6',
'auctionId': '1d1a030790a475'
}];
const request = spec.buildRequests(ivBidRequests);

expect(request.data).to.contain('"iv":"vet"')
})
});

describe('interpretResponse', () => {
Expand Down

0 comments on commit 3391a5c

Please sign in to comment.